Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: external local $refs resolution #88

Merged
merged 1 commit into from
Sep 22, 2023

Conversation

toomuchdesign
Copy link
Owner

What kind of change does this PR introduce?

Bug fix

What is the current behaviour?

$RefParser.bundle() not being able to resolve external local $refs since it misses the baseUrl information.

What is the new behaviour?

Provide $RefParser.bundle() with the absolute schema path instead of the schema entity and delegate bundling and YAML -> json conversion to it.

Does this PR introduce a breaking change?

No

Other information:

Please check if the PR fulfills these requirements:

  • Tests for the changes have been added
  • Docs have been added / updated
  • Relevant Changeset has been added

@changeset-bot
Copy link

changeset-bot bot commented Sep 22, 2023

🦋 Changeset detected

Latest commit: 37ed31e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
openapi-ts-json-schema Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@toomuchdesign toomuchdesign changed the title fix: external local resolution fix: external local $refs resolution Sep 22, 2023
@toomuchdesign toomuchdesign merged commit 27404ae into master Sep 22, 2023
@toomuchdesign toomuchdesign deleted the fix-external-local-ref-resolution branch September 22, 2023 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant